Messages in this thread | | | From | <> | Subject | Re: [PATCH 4/8] net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100 interface | Date | Tue, 22 Jan 2019 09:08:54 +0000 |
| |
Hi Rob,
On 22/01/2019 at 02:10, Rob Herring wrote: > On Wed, Jan 16, 2019 at 10:57:40AM +0100, Nicolas Ferre wrote: >> This removes a line left while adding the correct compatibility string for >> sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string. >> >> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com> >> --- >> Documentation/devicetree/bindings/net/macb.txt | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt >> index 3e17ac1d5d58..f5c414b10e27 100644 >> --- a/Documentation/devicetree/bindings/net/macb.txt >> +++ b/Documentation/devicetree/bindings/net/macb.txt >> @@ -3,8 +3,7 @@ >> Required properties: >> - compatible: Should be "cdns,[<chip>-]{macb|gem}" >> Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC. >> - Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs or the 10/100Mbit IP >> - available on sama5d3 SoCs. >> + Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs. > > Where is "atmel,sama5d3-macb"?
It's actually a couple of line below: line 13 of the resulting macb.txt file. It was already in the file when I removed the leftovers.
Do you advice to try to better sort entries in this file? Is there a common pattern?
Best regards, Nicolas
>> Use "cdns,np4-macb" for NP4 SoC devices. >> Use "cdns,at32ap7000-macb" for other 10/100 usage or use the generic form: "cdns,macb". >> Use "cdns,pc302-gem" for Picochip picoXcell pc302 and later devices based on >> -- >> 2.17.1 >> >
-- Nicolas Ferre
| |