| From | Greg Kroah-Hartman <> | Subject | [PATCH 4.14 31/59] OF: properties: add missing of_node_put | Date | Mon, 21 Jan 2019 14:43:56 +0100 |
| |
4.14-stable review patch. If anyone has any objections, please let me know.
------------------
From: Julia Lawall <Julia.Lawall@lip6.fr>
commit 28b170e88bc0c7509e6724717c15cb4b5686026e upstream.
Add an of_node_put when the result of of_graph_get_remote_port_parent is not available.
The semantic match that finds this problem is as follows (http://coccinelle.lip6.fr):
// <smpl> @r exists@ local idexpression e; expression x; @@ e = of_graph_get_remote_port_parent(...); ... when != x = e when != true e == NULL when != of_node_put(e) when != of_fwnode_handle(e) ( return e; | *return ...; ) // </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Cc: stable@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- drivers/of/property.c | 1 + 1 file changed, 1 insertion(+)
--- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -810,6 +810,7 @@ struct device_node *of_graph_get_remote_ if (!of_device_is_available(remote)) { pr_debug("not available for remote node\n"); + of_node_put(remote); return NULL; }
|