Messages in this thread | | | Date | Mon, 21 Jan 2019 14:13:36 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCHv2 1/3] perf report: Display s390 diagnostic counter sets |
| |
On Sun, Jan 20, 2019 at 07:18:14PM +0100, Jiri Olsa wrote: > On Thu, Jan 17, 2019 at 11:00:53AM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > --- a/tools/perf/util/python-ext-sources > > +++ b/tools/perf/util/python-ext-sources > > @@ -25,6 +25,7 @@ util/parse-branch-options.c > > util/rblist.c > > util/counts.c > > util/print_binary.c > > +util/s390-sample-raw.c > > util/strlist.c > > util/trace-event.c > > ../lib/rbtree.c > > hi, > this change breaks the python module: > > >>> import perf > Traceback (most recent call last): > File "<stdin>", line 1, in <module> > ImportError: ./perf.so: undefined symbol: color_fprintf > > changelog doesn't say anything about python related change
I made some chenages and movedthat raw sample code under s390.. which cured the python module, but I haven't tested it on s390.
Could you please check if code in here works for you: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/s390
if it works, I'll post it
thanks, jirka
| |