lkml.org 
[lkml]   [2019]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 4/4] hwrng: add OP-TEE based rng driver
On Mon, Jan 21, 2019 at 11:43:14AM +0100, Ard Biesheuvel wrote:
> On Mon, 21 Jan 2019 at 11:30, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, Jan 21, 2019 at 02:59:19PM +0530, Sumit Garg wrote:
> > > --- /dev/null
> > > +++ b/drivers/char/hw_random/optee-rng.c
> > > @@ -0,0 +1,272 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> >
> > Nice, but:
> >
> > <snip>
> >
> > > +MODULE_LICENSE("GPL");
> >
> > This string means "GPL2+", you need "GPLv2" here instead.
> >
>
> I think you need a space there: "GPL v2" or it doesn't get picked up
> correctly (or at least, it didn't use to)

Sorry, yes, see I even got it wrong :)

The correct strings are in include/linux/module.h

\
 
 \ /
  Last update: 2019-01-21 11:47    [W:0.050 / U:5.516 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site