Messages in this thread | | | Subject | Re: [PATCH v2 2/2] ARM: dts: imx6: Add support for Phytec phyBOARD i.MX6UL Segin | From | Martyn Welch <> | Date | Mon, 21 Jan 2019 09:40:54 +0000 |
| |
Hi Fabio,
On Fri, 2019-01-18 at 19:18 -0200, Fabio Estevam wrote: > diff --git a/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin- > > full.dts b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts > > new file mode 100644 > > index 000000000000..83cdf4fa10c0 > > --- /dev/null > > +++ b/arch/arm/boot/dts/imx6ul-phytec-phyboard-segin-full.dts > > @@ -0,0 +1,96 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2016 PHYTEC Messtechnik GmbH > > + * Author: Christian Hemp <c.hemp@phytec.de> > > + */ > > + > > +/dts-v1/; > > +#include "imx6ul-phytec-pcl063.dtsi" > > +#include "imx6ul-phytec-phyboard-segin.dtsi" > > +#include "imx6ul-phytec-peb-eval-01.dtsi" > > + > > +/ { > > + model = "Phytec phyBOARD-Segin i.MX6 UltraLite Full > > Featured"; > > + compatible = "phytec,imx6ul-pbacd10", "phytec,imx6ul- > > pcl063", > > + "fsl,imx6ul"; > > Better keep it in a single line? >
It makes it longer than 80 chars, but I'm not adverse to that.
> > +&ecspi3 { > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_ecspi3>; > > + cs-gpios = <&gpio1 20 GPIO_ACTIVE_HIGH>; > > + status = "okay"; > > + > > + spidev@0 { > > + compatible = "spidev"; > > Doesn't the kernel complain about spidev dts nodes? >
Oh, yes, it does when spidev is loaded...
Removing.
Martyn
| |