lkml.org 
[lkml]   [2019]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] usb: dwc3: gadget: don't remove the request if bus-expired
Date
Hi balbi:

>-----Original Message-----
>From: Felipe Balbi [mailto:felipe.balbi@linux.intel.com]
>Sent: Monday, January 14, 2019 4:13 PM
>To: Zengtao (B) <prime.zeng@hisilicon.com>
>Cc: Zengtao (B) <prime.zeng@hisilicon.com>; Greg Kroah-Hartman
><gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org;
>linux-kernel@vger.kernel.org
>Subject: Re: [PATCH] usb: dwc3: gadget: don't remove the request if
>bus-expired
>
>* PGP Signed by an unknown key
>
>
>Hi,
>
>Zeng Tao <prime.zeng@hisilicon.com> writes:
>> We have already returned EAGAIN for bus-expiry, and it's designed to
>> start with a future Frame number and start the transfer again. So we
>> should not remove the request for that case.
>>
>> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
>
>Do we need a Fixes tag here? How about Cc stable? Can you share
>tracepoints exposing the problem?
>

I am not sure that we need to Fixes tag, it's not related to any single patch, but
there is definitely something wrong, after rethinking it again, I found that there
are still some problems for this patch, for the reties inside the driver, we should not
remove the request, but if we return -EAGAIN to the gadget layer, we should because
the gadget will requeue the request again if we return -EAGAIN.

Any suggestions.

>
>thanks
>
>--
>balbi
>
>* Unknown Key
>* 0xE11A9906
\
 
 \ /
  Last update: 2019-01-21 10:35    [W:0.044 / U:13.744 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site