lkml.org 
[lkml]   [2019]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] riscv: treat cpu devicetree nodes without status as enabled
On Sat, Jan 19, 2019 at 01:43:58AM +0000, Paul Walmsley wrote:
> On Fri, 18 Jan 2019, Johan Hovold wrote:
>
> > Follow the Linux convention and treat devicetree nodes without a status
> > property as enabled rather than disabled, while also allowing "ok" as a
> > shorthand for "okay".
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
>
> ... although I probably would have phrased the commit message slightly
> differently - something like "Use of_device_is_available() in
> riscv_of_processor_hartid(), in place of an open-coded test." That frames
> the change as one that removes custom code in place of an existing
> standard function for the same purpose.

You're right, and that was my motivation too. In the end I decided to
highlight the side effect in case someone was perhaps unknowingly
relying on the current behaviour.

Thanks for the review!

Johan

\
 
 \ /
  Last update: 2019-01-21 10:00    [W:0.071 / U:14.292 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site