lkml.org 
[lkml]   [2019]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 6/9] drm/bridge: cdns: Separate DSI and D-PHY configuration
On Thu, Jan 17, 2019 at 08:33:38AM -0500, Sean Paul wrote:
> > @@ -768,49 +769,90 @@ static int cdns_dsi_mode2cfg(struct cdns_dsi *dsi,
> >
> > dsi_cfg->hsa = dpi_to_dsi_timing(tmp, bpp,
> > DSI_HSA_FRAME_OVERHEAD);
> > - dsi_htotal += dsi_cfg->hsa + DSI_HSA_FRAME_OVERHEAD;
> > - dsi_hss_hsa_hse_hbp += dsi_cfg->hsa + DSI_HSA_FRAME_OVERHEAD;
> > }
> >
> > dsi_cfg->hact = dpi_to_dsi_timing(mode_valid_check ?
> > mode->hdisplay : mode->crtc_hdisplay,
> > bpp, 0);
> > - dsi_htotal += dsi_cfg->hact;
> > + dsi_cfg->hfp = dpi_to_dsi_timing(mode_to_dpi_hfp(mode), bpp,
> > + DSI_HFP_FRAME_OVERHEAD);
>
> We're throwing away the mode_valid_check switch here to flip between crtc_h*
> value and h* value. Is that intentional? We're using it above for hdisplay, so
> it's a bit confusing.

ah, right, thanks for spotting this.

I'll resend a version with those changes, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-01-21 16:44    [W:0.052 / U:5.228 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site