Messages in this thread | | | Subject | Re: [PATCH 05/13] dt-bindings: leds: add DT bindings for max77650 | From | Jacek Anaszewski <> | Date | Sun, 20 Jan 2019 17:28:14 +0100 |
| |
Hi Bartosz,
Thank you for the patch.
On 1/18/19 2:42 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Add the DT binding document for the LEDs module of max77650. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > .../bindings/leds/leds-max77650.txt | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-max77650.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-max77650.txt b/Documentation/devicetree/bindings/leds/leds-max77650.txt > new file mode 100644 > index 000000000000..822b8893bc20 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-max77650.txt > @@ -0,0 +1,57 @@ > +LED driver for MAX77650 PMIC from Maxim Integrated. > + > +This module is part of the MAX77650 MFD device. For more details > +see Documentation/devicetree/bindings/mfd/max77650.txt. > + > +The LED controller is represented as a sub-node of the PMIC node on > +the device tree. > + > +This device has three current sinks. > + > +Required properties: > +-------------------- > +- compatible: Must be "maxim,max77650-leds" > +- #address-cells: Must be <1>. > +- #size-cells: Must be <0>. > + > +Each LED is represented as a sub-node of the LED-controller node. Up to > +three sub-nodes can be defined. > + > +Required properties of the sub-node: > +------------------------------------ > + > +- reg: Must be <0>, <1> or <2>. > + > +Optional properties of the sub-node: > +------------------------------------ > + > +- label: See Documentation/devicetree/bindings/leds/common.txt > +- linux,default-trigger: See Documentation/devicetree/bindings/leds/common.txt > + > +For more details, please refer to the generic GPIO DT binding document > +<devicetree/bindings/gpio/gpio.txt>. > + > +Example: > +-------- > + > + leds { > + compatible = "maxim,max77650-leds"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + led0 {
s/led0/led@0/
> + reg = <0>; > + label = "max77650:blue:usr0"; > + }; > + > + led1 {
s/led1/led@1/
> + reg = <1>; > + label = "max77650:red:usr1"; > + linux,default-trigger = "heartbeat"; > + }; > + > + led2 {
s/led2/led@2/
> + reg = <2>; > + label = "max77650:green:usr2"; > + };
Please remove "max77650:" from labels and add it in the driver.
> + }; >
-- Best regards, Jacek Anaszewski
| |