Messages in this thread |  | | Date | Wed, 2 Jan 2019 14:30:47 +0300 | | From | Dan Carpenter <> | | Subject | Re: [PATCH] rts5208: fix a missing check of ms read |
| |
On Thu, Dec 20, 2018 at 02:00:01PM -0600, Kangjie Lu wrote: > When ms_read_extra_data fails, the data read in "extra" buffer is > just incorrect and thus should be used. However, "extra" is used > in multiple places no matter ms_read_extra_data() fails or not. > The fix checks the status of ms_read_extra_data() and returns with > an error code upon its failure. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Looks good.
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
|  |