Messages in this thread Patch in this message | | | From | Chengguang Xu <> | Subject | [PATCH] uio: remove redundant check | Date | Sat, 19 Jan 2019 21:15:34 +0800 |
| |
It is not necessary to check idev->info several times under mutex lock, so just remove redundant check.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com> --- drivers/uio/uio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index 46e5c1c31ebe..effe72834c2f 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -494,7 +494,7 @@ static int uio_open(struct inode *inode, struct file *filep) goto err_infoopen; } - if (idev->info && idev->info->open) + if (idev->info->open) ret = idev->info->open(idev->info, inode); mutex_unlock(&idev->info_lock); if (ret) @@ -635,7 +635,7 @@ static ssize_t uio_write(struct file *filep, const char __user *buf, goto out; } - if (!idev->info || !idev->info->irq) { + if (!idev->info->irq) { retval = -EIO; goto out; } -- 2.17.2
| |