lkml.org 
[lkml]   [2019]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] ARM: dts: imx53-smd: Add OV5642 video capture support
Hi Steve,

On Sat, Jan 19, 2019 at 7:19 PM Steve Longerbeam <slongerbeam@gmail.com> wrote:
>
> Add video capture support from the OV5642 to IPU CSI0 on
> the i.MX53 SMD.
>
> Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>

Looks good, thanks:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

Only one minor nit below that perhaps Shawn could adjust while applying:

pmic: dialog@48 {
> compatible = "dlg,da9053", "dlg,da9052";
> reg = <0x48>;
> + interrupt-parent = <&gpio7>;
> + interrupts = <11 IRQ_TYPE_LEVEL_LOW>; /* low-level active IRQ at GPIO7_11 */
> +
> + regulators {
> + ldo7_reg: ldo7 {
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <3600000>;
> + regulator-always-on;
> + };
> +
> + ldo9_reg: ldo9 {
> + regulator-min-microvolt = <1250000>;
> + regulator-max-microvolt = <3650000>;
> + regulator-always-on;

regulator-always-on could be removed from the two regulators above
since they are used by the camera.

\
 
 \ /
  Last update: 2019-01-19 23:31    [W:0.230 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site