Messages in this thread | | | From | Fabio Estevam <> | Date | Sat, 19 Jan 2019 20:30:42 -0200 | Subject | Re: [PATCH 2/2] ARM: dts: imx53-smd: Add OV5642 video capture support |
| |
Hi Steve,
On Sat, Jan 19, 2019 at 7:19 PM Steve Longerbeam <slongerbeam@gmail.com> wrote: > > Add video capture support from the OV5642 to IPU CSI0 on > the i.MX53 SMD. > > Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
Looks good, thanks:
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Only one minor nit below that perhaps Shawn could adjust while applying:
pmic: dialog@48 { > compatible = "dlg,da9053", "dlg,da9052"; > reg = <0x48>; > + interrupt-parent = <&gpio7>; > + interrupts = <11 IRQ_TYPE_LEVEL_LOW>; /* low-level active IRQ at GPIO7_11 */ > + > + regulators { > + ldo7_reg: ldo7 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3600000>; > + regulator-always-on; > + }; > + > + ldo9_reg: ldo9 { > + regulator-min-microvolt = <1250000>; > + regulator-max-microvolt = <3650000>; > + regulator-always-on;
regulator-always-on could be removed from the two regulators above since they are used by the camera.
| |