Messages in this thread | | | Subject | Re: [PATCH] tty: moxa: Fix coding style issues | From | Joe Perches <> | Date | Sat, 19 Jan 2019 14:11:39 -0800 |
| |
On Sat, 2019-01-19 at 17:05 -0500, Antoine Robertson wrote: > Fix coding style issues [] > diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c [] > @@ -74,8 +74,7 @@ enum { > MOXA_BOARD_CP204J, > }; > > -static char *moxa_brdname[] = > -{ > +static char *moxa_brdname[] = {
If you're going to fix this, might as well make it static const char *
> "C218 Turbo PCI series", > "C218 Turbo ISA series", > "C320 Turbo PCI series", [] > @@ -1357,8 +1355,7 @@ static void moxa_new_dcdstate(struct moxa_port *p, u8 dcd) > spin_unlock_irqrestore(&p->port.lock, flags); > if (!dcd) > tty_port_tty_hangup(&p->port, true); > - } > - else > + } else
and use } else {
> spin_unlock_irqrestore(&p->port.lock, flags); > }
| |