lkml.org 
[lkml]   [2019]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/3] arm: omap_hwmod disable ick autoidling when a hwmod requires that
Hi,

On Fri, 18 Jan 2019 10:36:30 -0800
Tony Lindgren <tony@atomide.com> wrote:

[...]
> til the next workaround.
>
> > That flags also causes the iclk being enabled/disabled
> > manually.
>
> Yes but SWSUP_IDLE for the interface clock to me currently
> just means:
>
> "manually enable and disable ocp interface clock"
>
well, if we want to manually disable it and not automatically,
we have to disable autoidle or it will be automatically disabled.

Disabling it manually when it is already auto-disabled (by autoidle) is
just practically a no-op towards the clock.

> and with your changes it becomes:
>
> "manually enable and disable ocp interface clock and block
> autoidle while in use".
>
> So aren't we now changing the way things behave in general
> for SWSUP_IDLE?
>
Yes, we are, so proper testing is needed. But If I read those comments
it was always intended this way but not fully implemented because it
appeared to be more work like needing a usecounter (which my patchset
also adds) for that autoidle flag.

Regards,
Andreas
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-01-18 20:39    [W:0.079 / U:1.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site