lkml.org 
[lkml]   [2019]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH/RFC] Make perf_event_open() propagate errors for use in bpf_perf_event_open()
On Fri, Jan 18, 2019 at 12:09:38PM -0300, Arnaldo Carvalho de Melo wrote:
> commit 1b3b3dee572d0b77a316ab6715091201be6832de
> Author: Arnaldo Carvalho de Melo <acme@redhat.com>
> Date: Fri Jan 11 13:20:20 2019 -0300
>
> perf: Make perf_event_output() propagate the output() return
>
> For the original mode of operation it isn't needed, since we report back
> errors via PERF_RECORD_LOST records in the ring buffer, but for use in
> bpf_perf_event_output() it is convenient to return the errors, basically
> -ENOSPC.
>
> Currently bpf_perf_event_output() returns an error indication, the last
> thing it does, which is to push it to the ring buffer is that can fail
> and if so, this failure won't be reported back to its users, fix it.
>
> Reported-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Tested-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Link: https://lkml.kernel.org/r/20190111155538.GX22483@kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

/me hates on git-format :-)

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

\
 
 \ /
  Last update: 2019-01-18 17:20    [W:0.121 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site