[lkml]   [2019]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] driver core: move device->knode_class to device_private
On Fri, Jan 18, 2019 at 10:34:59AM +0800, Wei Yang wrote:
> As the description of struct device_private says, it stores data which
> is private to driver core. And it already has similar fields like:
> knode_parent, knode_driver, knode_driver and knode_bus. This look it is
> more proper to put knode_class together with those fields to make it
> private to driver core.
> This patch move device->knode_class to device_private to make it comply
> with code convention.
> Signed-off-by: Wei Yang <>
> Reviewed-by: Rafael J. Wysocki <>

Thanks for this. There are a number of other variables that should move
into this structure, if you want to take a look into doing that.

greg k-h

 \ /
  Last update: 2019-01-18 16:57    [W:0.080 / U:1.356 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site