Messages in this thread | | | Date | Fri, 18 Jan 2019 10:40:10 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v4] cpufreq: s5pv210: Defer probe if getting regulators fail |
| |
On 14-01-19, 08:51, Krzysztof Kozlowski wrote: > On Sun, 13 Jan 2019 at 20:58, Paweł Chmiel > <pawel.mikolaj.chmiel@gmail.com> wrote: > > > > There is possibility, that when probing driver, regulators are not yet > > initialized. In this case we should return EPROBE_DEFER and wait till > > they're initialized, since they're required currently for cpufreq driver > > to work. Also move regulator initialization code at beginning of probe, > > so we can defer as fast as posibble. > > > > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> > > --- > > Changes from v3: > > - Zero dmc_base pointers after unmapping them > > - If getting vddarm regulator fails just return, no need to do goto > > jump which would do the same > > > > Changes from v2: > > - Handle all error paths in probe > > > > Changes from v1: > > - Fix compilation error > > - Reorganize code so it's smaller > > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Applied, thanks.
-- viresh
| |