lkml.org 
[lkml]   [2019]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] riscv: treat cpu devicetree nodes without status as enabled
On Fri, 18 Jan 2019, Johan Hovold wrote:

> Follow the Linux convention and treat devicetree nodes without a status
> property as enabled rather than disabled, while also allowing "ok" as a
> shorthand for "okay".
>
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>

... although I probably would have phrased the commit message slightly
differently - something like "Use of_device_is_available() in
riscv_of_processor_hartid(), in place of an open-coded test." That frames
the change as one that removes custom code in place of an existing
standard function for the same purpose.


- Paul

\
 
 \ /
  Last update: 2019-01-19 02:51    [W:0.143 / U:4.216 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site