Messages in this thread | | | Date | Thu, 17 Jan 2019 10:51:02 +0100 | From | Ingo Molnar <> | Subject | Re: [GIT PULL] timer fix |
| |
* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> > - if (timr->it_requeue_pending == info->si_sys_private) { > > + if (timr->it_interval && timr->it_requeue_pending == info->si_sys_private) { > > timr->kclock->timer_rearm(timr); > > FWIW, with this patch the vanilla glibc 2.28 self tests > rt/tst-cputimer1, rt/tst-cputimer2, and rt/tst-cputimer3 > start to fail on s390: > > rt/tst-cputimer1.out: > clock_gettime returned timespec = { 0, 117181 } > clock_getres returned timespec = { 0, 1 } > Timed out: killed the child process > rt/tst-cputimer1.test-result: > FAIL: rt/tst-cputimer1 > original exit status 1 > > rt/tst-cputimer2.out: > clock_gettime returned timespec = { 0, 9686 } > clock_getres returned timespec = { 0, 1 } > Timed out: killed the child process > rt/tst-cputimer2.test-result: > FAIL: rt/tst-cputimer2 > original exit status 1 > > rt/tst-cputimer3.out: > clock_gettime returned timespec = { 0, 0 } > clock_getres returned timespec = { 0, 1 } > Timed out: killed the child process > rt/tst-cputimer3.test-result: > FAIL: rt/tst-cputimer3 > original exit status 1 > > I haven't looked any further into this, just reporting.. otherwise the > test systems seem to be healthy.
Could you please check whether the top commit in tip:timers/urgent fixes it:
93ad0fc088c5: posix-cpu-timers: Unbreak timer rearming
?
It's in tip:master as well and should show up in linux-next tomorrow.
Thanks,
Ingo
| |