Messages in this thread Patch in this message | | | From | Mathieu Malaterre <> | Subject | [PATCH v2 2/2] bpf: Correctly annotate implicit fall through in bpf_base_func_proto | Date | Wed, 16 Jan 2019 20:35:41 +0100 |
| |
There is a plan to build the kernel with -Wimplicit-fallthrough and this place in the code produced a warnings (W=1).
To preserve as much of the existing comment only change a ‘:’ into a ‘,’. This is enough change, to match the regular expression expected by GCC.
This commit remove the following warning:
net/core/filter.c:5310:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Mathieu Malaterre <malat@debian.org> --- v2: reword the patch subject, remove a typo
net/core/filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/filter.c b/net/core/filter.c index 2b3b436ef545..d9076e609fca 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -5309,7 +5309,7 @@ bpf_base_func_proto(enum bpf_func_id func_id) case BPF_FUNC_trace_printk: if (capable(CAP_SYS_ADMIN)) return bpf_get_trace_printk_proto(); - /* else: fall through */ + /* else, fall through */ default: return NULL; } -- 2.19.2
| |