lkml.org 
[lkml]   [2019]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 0/7] Introduce STPMIC1 PMIC Driver
On Mon, 14 Jan 2019, dmitry.torokhov@gmail.com wrote:

> On Fri, Dec 14, 2018 at 12:47:01PM +0000, Lee Jones wrote:
> > On Fri, 30 Nov 2018, Pascal PAILLET-LME wrote:
> >
> > > The goal of this patch-set is to propose a driver for the STPMIC1 PMIC from
> > > STMicroelectronics.
> > > The STPMIC1 regulators supply power to an application processor as well as
> > > to external system peripherals such as DDR, Flash memories and system
> > > devices. It also features onkey button input and an hardware watchdog.
> > > The STPMIC1 is controlled via I2C.
> > >
> > > Main driver is drivers/mfd/stpmic1 that handle I2C regmap configuration and
> > > irqchip. stpmic1_regulator, stpmic1_onkey and stpmic1_wdt need stpmic1 mfd
> > > as parent.
> > >
> > > STPMIC1 MFD and regulator drivers maybe mandatory at boot time.
> > >
> > > Pascal Paillet (7):
> > > changes in v7:
> > > * rebase on regul/for-next
> > >
> > > dt-bindings: mfd: document stpmic1
> > > mfd: stpmic1: add stpmic1 driver
> > > dt-bindings: input: document stpmic1 pmic onkey
> > > input: stpmic1: add stpmic1 onkey driver
> > > dt-bindings: watchdog: document stpmic1 pmic watchdog
> > > watchdog: stpmic1: add stpmic1 watchdog driver
> > > regulator: stpmic1: fix regulator_lock usage
> >
> > Could you please remove any patches which have been applied and
> > [RESEND]?
> >
> > Also, is Dmitry planning on Acking:
> >
> > dt-bindings: input: document stpmic1 pmic onkey
> >
> > ... or is Rob's Ack enough?
>
> For bindings I normally defer to Rob (unless I see something that really
> bugs me and then I'll speak up).

I usually do the opposite. Seeing as Rob is pretty heavily laden with
DT patches, I tend to review/apply patches which do not add new DT
properties and/or are obvious/trivial and leave Rob to the rest.

Your train-set though of course, your decision.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2019-01-16 09:15    [W:0.121 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site