Messages in this thread | | | From | Rob Herring <> | Date | Wed, 16 Jan 2019 13:03:29 -0600 | Subject | Re: [PATCH 2/3] OF: properties: add missing of_node_put |
| |
On Sun, Jan 13, 2019 at 4:21 AM Julia Lawall <Julia.Lawall@lip6.fr> wrote: > > Add an of_node_put when the result of of_graph_get_remote_port_parent is > not available. > > The semantic match that finds this problem is as follows > (http://coccinelle.lip6.fr): > > // <smpl> > @r exists@ > local idexpression e; > expression x; > @@ > e = of_graph_get_remote_port_parent(...); > ... when != x = e > when != true e == NULL > when != of_node_put(e) > when != of_fwnode_handle(e) > ( > return e; > | > *return ...; > ) > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > drivers/of/property.c | 1 + > 1 file changed, 1 insertion(+)
Applied, thanks.
Rob
| |