lkml.org 
[lkml]   [2019]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Staging: fbtft: Switch to the gpio descriptor interface
On Tue, Jan 15, 2019 at 04:02:31PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Jan 15, 2019 at 10:17:09AM +0530, Nishad Kamdar wrote:
> > This switches the fbtft driver to use GPIO descriptors
> > rather than numerical gpios:
> >
> > Utilize the GPIO library's intrinsic handling of OF GPIOs
> > and polarity. If the line is flagged active low, gpiolib
> > will deal with this.
> >
> > Remove gpios from platform device structure. Neither assign
> > statically numbers to gpios in platform device nor allow
> > gpios to be parsed as module parameters.
> >
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > Changes in v2:
> > - Merge all patches in a single patch. This is because the
> > first patch changes par->gpio from an int to a pointer
> > so all the checks have to be updated in the same patch.
> > Otherwie it breaks 'git bisect'.
>
> The "v2" information goes below the --- line please.
>
> Also, I got 2 copies of this, both different, so I have no idea which to
> apply. Please fix up and resend a v3.
>
Sorry for the confusion. I'll fix and resend.

> thanks,
>
> greg k-h

Thanks for the review.

Regards,
Nishad

\
 
 \ /
  Last update: 2019-01-16 18:15    [W:0.170 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site