lkml.org 
[lkml]   [2019]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] sb1000: fix a couple of indentation issues
From
Date
On Thu, 2019-01-17 at 00:13 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an if statement and a return statement that are incorrectly
> indented. Fix these.
[]
> diff --git a/drivers/net/sb1000.c b/drivers/net/sb1000.c
[]
> @@ -540,12 +540,12 @@ sb1000_activate(const int ioaddr[], const char* name)
> if ((status = card_send_command(ioaddr, name, Command1, st)))
> return status;
> if (st[3] != 0xf1) {
> - if ((status = sb1000_start_get_set_command(ioaddr, name)))
> + if ((status = sb1000_start_get_set_command(ioaddr, name)))

Probably better to remove the assignment in the if at the same time.

status = sb1000_start_get_set_command(ioaddr, name);
if (status)

> return status;
> return -EIO;
> }
> udelay(1000);
> - return sb1000_start_get_set_command(ioaddr, name);
> + return sb1000_start_get_set_command(ioaddr, name);
> }
>
> /* get SB1000 firmware version */

\
 
 \ /
  Last update: 2019-01-17 01:21    [W:0.061 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site