Messages in this thread | | | Date | Tue, 15 Jan 2019 18:43:46 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v4] staging: Mediatek: Use individual config flags in Makefile |
| |
On Tue, Jan 15, 2019 at 10:29:18AM -0700, George Hilliard wrote: > These drivers can be useful on other MT76xx SoCs, which have compatible > peripherals. The drivers were selectable in Kconfig, but they were > quietly excluded from the build because the SOC_MT7621 chip was not > selected. So, make the Makefiles use the same flags as Kconfig for > these drivers. > > mt7621-dma and mt7621-dts are left alone because they truly do require > that SoC. > > I have personally confirmed that the mt7621-spi driver works on the > MT7688, which was what prompted this change. > > Cc: linux-kernel@vger.kernel.org > Cc: devel@driverdev.osuosl.org > Cc: NeilBrown <neil@brown.name> > Cc: sergio.paracuellos@gmail.com > Signed-off-by: George Hilliard <thirtythreeforty@gmail.com> > --- > Changes in v2..v4: > - Also use individual flags for mt7621-pci and the new mt7621-pci-phy > - Slightly revise commit message
You also rebased this patch, right?
Anyway, applying this patch, I get the following build error:
CC [M] drivers/staging/mt7621-mmc/sd.o CC [M] drivers/staging/mt7621-mmc/dbg.o drivers/staging/mt7621-mmc/sd.c:48:10: fatal error: asm/mach-ralink/ralink_regs.h: No such file or directory #include <asm/mach-ralink/ralink_regs.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[3]: *** [scripts/Makefile.build:277: drivers/staging/mt7621-mmc/sd.o] Error 1 make[3]: *** Waiting for unfinished jobs.... drivers/staging/mt7621-mmc/dbg.c: In function ‘msdc_debug_proc_write’: drivers/staging/mt7621-mmc/dbg.c:237:12: warning: unused variable ‘size’ [-Wunused-variable] int mode, size; ^~~~ drivers/staging/mt7621-mmc/dbg.c:237:6: warning: unused variable ‘mode’ [-Wunused-variable] int mode, size; ^~~~ make[2]: *** [scripts/Makefile.build:492: drivers/staging/mt7621-mmc] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [scripts/Makefile.build:492: drivers/staging] Error 2 make[1]: *** Waiting for unfinished jobs....
So I can't take this patch as is, sorry.
Please fix.
thanks,
greg k-h
| |