lkml.org 
[lkml]   [2019]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 10/27] USB: storage: dont insert sane sense for SPC3+ when bad sense specified
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Icenowy Zheng <icenowy@aosc.io>

    commit c5603d2fdb424849360fe7e3f8c1befc97571b8c upstream.

    Currently the code will set US_FL_SANE_SENSE flag unconditionally if
    device claims SPC3+, however we should allow US_FL_BAD_SENSE flag to
    prevent this behavior, because SMI SM3350 UFS-USB bridge controller,
    which claims SPC4, will show strange behavior with 96-byte sense
    (put the chip into a wrong state that cannot read/write anything).

    Check the presence of US_FL_BAD_SENSE when assuming US_FL_SANE_SENSE on
    SPC4+ devices.

    Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
    Cc: stable <stable@vger.kernel.org>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/storage/scsiglue.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    --- a/drivers/usb/storage/scsiglue.c
    +++ b/drivers/usb/storage/scsiglue.c
    @@ -251,8 +251,12 @@ static int slave_configure(struct scsi_d
    if (!(us->fflags & US_FL_NEEDS_CAP16))
    sdev->try_rc_10_first = 1;

    - /* assume SPC3 or latter devices support sense size > 18 */
    - if (sdev->scsi_level > SCSI_SPC_2)
    + /*
    + * assume SPC3 or latter devices support sense size > 18
    + * unless US_FL_BAD_SENSE quirk is specified.
    + */
    + if (sdev->scsi_level > SCSI_SPC_2 &&
    + !(us->fflags & US_FL_BAD_SENSE))
    us->fflags |= US_FL_SANE_SENSE;

    /*

    \
     
     \ /
      Last update: 2019-01-15 17:41    [W:4.097 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site