Messages in this thread | | | Subject | Re: [PATCH v2 1/7] dt-bindings: soc: qcom: Add AOSS QMP binding | From | Stephen Boyd <> | Date | Mon, 14 Jan 2019 14:30:52 -0800 |
| |
Quoting Bjorn Andersson (2019-01-06 00:09:09) > Add binding for the QMP based side-channel communication mechanism to > the AOSS, which is used to control resources not exposed through the > RPMh interface. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
one nit below.
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt > new file mode 100644 > index 000000000000..9b0d9785efe0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt > @@ -0,0 +1,57 @@ > += EXAMPLE > + > +The following example represents the AOSS side-channel message RAM and the > +mechanism exposing the power-domains, as found in SDM845. > + > + aoss_qmp: qmp@c300000 { > + compatible = "qcom,sdm845-aoss-qmp"; > + reg = <0x0c300000 0x100000>; > + interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>; > + mboxes = <&apss_shared 0>; > + > + #power-domain-cells = <1>;
This is weirdly tabbed out.
| |