Messages in this thread | | | Date | Mon, 14 Jan 2019 19:01:42 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 1/2 v6] kdump: add the vmcoreinfo documentation |
| |
On Mon, Jan 14, 2019 at 05:48:48PM +0000, Kazuhito Hagio wrote: > As for makedumpfile, it will be not impossible to remove the > init_uts_ns.name.relase (OSRELEASE), but some fixes are needed. > Because historically OSRELEASE has been a kind of a mandatory entry > in vmcoreinfo from the beginning of vmcoreinfo, so makedumpfile uses > its existence to check whether a vmcoreinfo is sane.
Well, init_uts_ns is exported in vmcoreinfo anyway - makedumpfile can simply test init_uts_ns.name.release just as well. And the "historically" argument doesn't matter because vmcoreinfo is not an ABI.
So makedumpfile needs to be changed to check that new export.
> Also, I think crash also will need to be fixed if it is removed.
Yes, I'm expecting user tools to be fixed and then exports removed.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |