lkml.org 
[lkml]   [2019]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 3/7] drm: meson: Cleanup on drm_display_mode print str
From
Date
Hi Shayenne,

On 10/01/2019 18:16, Shayenne Moura wrote:
> This patch adjust the print string of drm_display_mode object
> to remove drm_mode_object dependency in meson files.
>
> Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>

Totally missed this one... please respect MAINTAINERS and CC the linux-amlogic ML otherwise I'll miss it again.

> ---
> Changes in v2:
> - Use DRM_MODE_FMT/ARG macros (Daniel)
> - Make the commit message more clear
>
> Changes in v3:
> - No changes
>
> drivers/gpu/drm/meson/meson_dw_hdmi.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> index d8c5cc34e22e..0b6c29cdd934 100644
> --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c
> +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c
> @@ -365,7 +365,7 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, void *data,
> unsigned int wr_clk =
> readl_relaxed(priv->io_base + _REG(VPU_HDMI_SETTING));
>
> - DRM_DEBUG_DRIVER("%d:\"%s\"\n", mode->base.id, mode->name);
> + DRM_DEBUG_DRIVER("\"%s\"\n", mode->name);
>
> /* Enable clocks */
> regmap_update_bits(priv->hhi, HHI_HDMI_CLK_CNTL, 0xffff, 0x100);
> @@ -555,12 +555,7 @@ dw_hdmi_mode_valid(struct drm_connector *connector,
> int vic = drm_match_cea_mode(mode);
> enum drm_mode_status status;
>
> - DRM_DEBUG_DRIVER("Modeline %d:\"%s\" %d %d %d %d %d %d %d %d %d %d 0x%x 0x%x\n",
> - mode->base.id, mode->name, mode->vrefresh, mode->clock,
> - mode->hdisplay, mode->hsync_start,
> - mode->hsync_end, mode->htotal,
> - mode->vdisplay, mode->vsync_start,
> - mode->vsync_end, mode->vtotal, mode->type, mode->flags);
> + DRM_DEBUG_DRIVER("Modeline " DRM_MODE_FMT "\n", DRM_MODE_ARG(mode));
>
> /* Check against non-VIC supported modes */
> if (!vic) {
> @@ -650,8 +645,7 @@ static void meson_venc_hdmi_encoder_mode_set(struct drm_encoder *encoder,
> struct meson_drm *priv = dw_hdmi->priv;
> int vic = drm_match_cea_mode(mode);
>
> - DRM_DEBUG_DRIVER("%d:\"%s\" vic %d\n",
> - mode->base.id, mode->name, vic);
> + DRM_DEBUG_DRIVER("\"%s\" vic %d\n", mode->name, vic);
>
> /* VENC + VENC-DVI Mode setup */
> meson_venc_hdmi_mode_set(priv, vic, mode);
>

Anyway it's ok for me.

Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>

Neil

\
 
 \ /
  Last update: 2019-01-14 16:55    [W:0.045 / U:23.020 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site