Messages in this thread Patch in this message | | | From | Christoph Hellwig <> | Subject | [PATCH 3/8] parisc: turn GET_IOC into an inline function | Date | Mon, 14 Jan 2019 12:23:48 +0100 |
| |
This makes the function both more readable and more typesafe.
Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/parisc/iommu.h | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/parisc/iommu.h b/drivers/parisc/iommu.h index c72c4fe51a3a..94d5eae98bf6 100644 --- a/drivers/parisc/iommu.h +++ b/drivers/parisc/iommu.h @@ -24,10 +24,14 @@ static inline void *parisc_walk_tree(struct device *dev) return dev->platform_data; } -#define GET_IOC(dev) ({ \ - void *__pdata = parisc_walk_tree(dev); \ - __pdata ? HBA_DATA(__pdata)->iommu : NULL; \ -}) +static inline struct ioc *GET_IOC(struct device *dev) +{ + struct pci_hba_data *pdata = parisc_walk_tree(dev); + + if (!pdata) + return NULL; + return pdata->iommu; +} #ifdef CONFIG_IOMMU_CCIO void *ccio_get_iommu(const struct parisc_device *dev); -- 2.20.1
| |