lkml.org 
[lkml]   [2019]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] sysrq: Remove duplicated sysrq message
On (01/11/19 17:20), Petr Mladek wrote:
> The commit 97f5f0cd8cd0a0544 ("Input: implement SysRq as a separate input
> handler") added pr_fmt() definition. It caused a duplicated message
> prefix in the sysrq header messages, for example:
>
> [ 177.053931] sysrq: SysRq : Show backtrace of all active CPUs
> [ 742.864776] sysrq: SysRq : HELP : loglevel(0-9) reboot(b) crash(c)
>
> Fixes: 97f5f0cd8cd0a05 ("Input: implement SysRq as a separate input handler")
> Signed-off-by: Petr Mladek <pmladek@suse.com>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>



A side note:

> - pr_cont("This sysrq operation is disabled.\n");
> + pr_info("This sysrq operation is disabled.\n");

I wouldn't mind this messages to become more informative.

+ pr_info("sysrq 0x%x operation is disabled.\n", key);

?

A bunch of "This sysrq operation is disabled" in serial0 log file
(post mortem) is not very helpful.

-ss

\
 
 \ /
  Last update: 2019-01-14 06:52    [W:0.066 / U:7.456 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site