Messages in this thread | | | Subject | Re: [PATCH v3] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template | From | Bart Van Assche <> | Date | Sun, 13 Jan 2019 20:54:35 -0800 |
| |
On 1/13/19 8:42 PM, Nathan Chancellor wrote: > @@ -1292,7 +1292,7 @@ int esas2r_ioctl_handler(void *hostdata, int cmd, void __user *arg) > ioctl = memdup_user(arg, sizeof(struct atto_express_ioctl)); > if (IS_ERR(ioctl)) { > esas2r_log(ESAS2R_LOG_WARN, > - "ioctl_handler access_ok failed for cmd %d, " > + "ioctl_handler access_ok failed for cmd %u, " > "address %p", cmd, > arg); > return PTR_ERR(ioctl);
If you have to repost this patch, please use that opportunity to join the above split strings. Additionally, since this patch touches much more SCSI code than ATA code I think it should have been sent to Martin instead of to Jens. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
| |