Messages in this thread Patch in this message | | | From | Ivan Mironov <> | Subject | [RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI | Date | Mon, 14 Jan 2019 07:36:14 +0500 |
| |
Existing code disables watchdog on NMI right before completely hanging the system.
There are two problems here:
* First, watchdog is expected to reset the system in a case of such failure, no matter what. * Second, this code has no effect if there are more than one watchdog.
Signed-off-by: Ivan Mironov <mironov.ivan@gmail.com> --- drivers/watchdog/hpwdt.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index ef30c7e9728d..2467e6bc25c2 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -170,8 +170,6 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs) if (ilo5 && !pretimeout && !mynmi) return NMI_DONE; - hpwdt_stop(); - hex_byte_pack(panic_msg, mynmi); nmi_panic(regs, panic_msg); -- 2.20.1
| |