lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 13/47] packet: validate address length
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Willem de Bruijn <willemb@google.com>

    [ Upstream commit 99137b7888f4058087895d035d81c6b2d31015c5 ]

    Packet sockets with SOCK_DGRAM may pass an address for use in
    dev_hard_header. Ensure that it is of sufficient length.

    Reported-by: syzbot <syzkaller@googlegroups.com>
    Signed-off-by: Willem de Bruijn <willemb@google.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/packet/af_packet.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/net/packet/af_packet.c
    +++ b/net/packet/af_packet.c
    @@ -2275,6 +2275,8 @@ static int tpacket_snd(struct packet_soc
    proto = saddr->sll_protocol;
    addr = saddr->sll_addr;
    dev = dev_get_by_index(sock_net(&po->sk), saddr->sll_ifindex);
    + if (addr && dev && saddr->sll_halen < dev->addr_len)
    + goto out;
    }

    err = -ENXIO;
    @@ -2436,6 +2438,8 @@ static int packet_snd(struct socket *soc
    proto = saddr->sll_protocol;
    addr = saddr->sll_addr;
    dev = dev_get_by_index(sock_net(sk), saddr->sll_ifindex);
    + if (addr && dev && saddr->sll_halen < dev->addr_len)
    + goto out;
    }

    err = -ENXIO;

    \
     
     \ /
      Last update: 2019-01-11 16:13    [W:2.612 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site