lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 056/105] scsi: lpfc: do not set queue->page_count to 0 if pc_sli4_params.wqpcnt is invalid
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ewan D. Milne <emilne@redhat.com>

    commit 4e87eb2f46ea547d12a276b2e696ab934d16cfb6 upstream.

    Certain older adapters such as the OneConnect OCe10100 may not have a valid
    wqpcnt value. In this case, do not set queue->page_count to 0 in
    lpfc_sli4_queue_alloc() as this will prevent the driver from initializing.

    Fixes: 895427bd01 ("scsi: lpfc: NVME Initiator: Base modifications")
    Cc: stable@vger.kernel.org # 4.11+
    Signed-off-by: Ewan D. Milne <emilne@redhat.com>
    Reviewed-by: Laurence Oberman <loberman@redhat.com>
    Tested-by: Laurence Oberman <loberman@redhat.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/lpfc/lpfc_sli.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/scsi/lpfc/lpfc_sli.c
    +++ b/drivers/scsi/lpfc/lpfc_sli.c
    @@ -13941,7 +13941,8 @@ lpfc_sli4_queue_alloc(struct lpfc_hba *p
    hw_page_size))/hw_page_size;

    /* If needed, Adjust page count to match the max the adapter supports */
    - if (queue->page_count > phba->sli4_hba.pc_sli4_params.wqpcnt)
    + if (phba->sli4_hba.pc_sli4_params.wqpcnt &&
    + (queue->page_count > phba->sli4_hba.pc_sli4_params.wqpcnt))
    queue->page_count = phba->sli4_hba.pc_sli4_params.wqpcnt;

    INIT_LIST_HEAD(&queue->list);

    \
     
     \ /
      Last update: 2019-01-11 16:02    [W:4.397 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site