lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] dt-bindings: gnss: add gtop binding
On Fri, Dec 28, 2018 at 11:50:33AM +0100, Loys Ollivier wrote:
> Add binding for GlobalTop GNSS receivers.
>
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
> ---
> Documentation/devicetree/bindings/gnss/gtop.txt | 33 +++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gnss/gtop.txt
>
> diff --git a/Documentation/devicetree/bindings/gnss/gtop.txt b/Documentation/devicetree/bindings/gnss/gtop.txt
> new file mode 100644
> index 000000000000..24c86703aa46
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gnss/gtop.txt
> @@ -0,0 +1,33 @@
> +GlobalTop GNSS Receiver DT binding
> +
> +The GlobalTop GNSS receivers uses UART interfaces.
> +
> +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic
> +properties.
> +
> +Required properties:
> +
> +- compatible : Must be
> +
> + "globaltop,pa6h"
> +
> +- vcc-supply : Main voltage regulator
> +
> +Optional properties:
> +
> +- timepulse-gpios : Time pulse GPIO
> +- v-bckp-supply : Backup voltage regulator
> +
> +Example:
> +
> +&uart_A {
> + status = "okay";

Don't show status in examples.

> + pinctrl-0 = <&uart_a_pins>;
> + pinctrl-names = "default";
> +
> + gnss {
> + compatible = "globaltop,pa6h";
> + vcc-supply = <&vcc_3v3>;
> + current-speed = <9600>;

Shouldn't the driver know what speed the device operates at?

If you do use this, then it needs to be documented as to when it is
needed.

> + };
> +};
> --
> 2.7.4
>

\
 
 \ /
  Last update: 2019-01-11 15:46    [W:0.088 / U:1.896 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site