lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 52/65] ceph: dont update importing caps mseq when handing cap export
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Yan, Zheng <zyan@redhat.com>

    commit 3c1392d4c49962a31874af14ae9ff289cb2b3851 upstream.

    Updating mseq makes client think importer mds has accepted all prior
    cap messages and importer mds knows what caps client wants. Actually
    some cap messages may have been dropped because of mseq mismatch.

    If mseq is left untouched, importing cap's mds_wanted later will get
    reset by cap import message.

    Cc: stable@vger.kernel.org
    Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
    Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ceph/caps.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/fs/ceph/caps.c
    +++ b/fs/ceph/caps.c
    @@ -3569,7 +3569,6 @@ retry:
    tcap->cap_id = t_cap_id;
    tcap->seq = t_seq - 1;
    tcap->issue_seq = t_seq - 1;
    - tcap->mseq = t_mseq;
    tcap->issued |= issued;
    tcap->implemented |= issued;
    if (cap == ci->i_auth_cap)

    \
     
     \ /
      Last update: 2019-01-11 15:46    [W:4.041 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site