lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.20 18/65] ALSA: cs46xx: Potential NULL dereference in probe
    Date
    4.20-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 1524f4e47f90b27a3ac84efbdd94c63172246a6f upstream.

    The "chip->dsp_spos_instance" can be NULL on some of the ealier error
    paths in snd_cs46xx_create().

    Reported-by: "Yavuz, Tuba" <tuba@ece.ufl.edu>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/pci/cs46xx/dsp_spos.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/sound/pci/cs46xx/dsp_spos.c
    +++ b/sound/pci/cs46xx/dsp_spos.c
    @@ -903,6 +903,9 @@ int cs46xx_dsp_proc_done (struct snd_cs4
    struct dsp_spos_instance * ins = chip->dsp_spos_instance;
    int i;

    + if (!ins)
    + return 0;
    +
    snd_info_free_entry(ins->proc_sym_info_entry);
    ins->proc_sym_info_entry = NULL;


    \
     
     \ /
      Last update: 2019-01-11 15:43    [W:5.199 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site