lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] gpiolib: fix line event timestamps for nested irqs
pt., 11 sty 2019 o 13:19 Linus Walleij <linus.walleij@linaro.org> napisał(a):
>
> On Fri, Jan 4, 2019 at 11:32 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > Nested interrupts run inside the calling thread's context and the top
> > half handler is never called which means that we never read the
> > timestamp.
> >
> > This issue came up when trying to read line events from a gpiochip
> > using regmap_irq_chip for interrupts.
> >
> > Fix it by reading the timestamp from the irq thread function if it's
> > still 0 by the time the second handler is called.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Oh that's right. Should this not have Fixes: and Cc: stable?
>
> > + /*
> > + * We may be running from a nested threaded interrupt in which case
> > + * we didn't get the timestamp from lineevent_irq_handler().
> > + */
> > + if (!le->timestamp)
> > + le->timestamp = ktime_get_real_ns();
> > +
> > ge.timestamp = le->timestamp;
>
> I would merge these:
>
> if (!le->timestamp)
> ge.timestamp = ktime_get_real_ns();
> else
> ge.timestamp = le->timestamp;
>
> Yours,
> Linus Walleij

I'll fix both issues and resend.

Bart

\
 
 \ /
  Last update: 2019-01-11 14:47    [W:0.037 / U:9.704 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site