Messages in this thread | | | Date | Fri, 11 Jan 2019 02:09:50 -0800 | From | Omar Sandoval <> | Subject | Re: [PATCH] blk_types.h: Use REQ_OP_WRITE in op_is_write |
| |
On Sat, Dec 22, 2018 at 08:03:54AM -0200, Marcos Paulo de Souza wrote: > Instead of just using plain '1', as it improves readability. > > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> > --- > include/linux/blk_types.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index 1dcf652ba0aa..905c666a0101 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -377,7 +377,7 @@ static inline void bio_set_op_attrs(struct bio *bio, unsigned op, > > static inline bool op_is_write(unsigned int op) > { > - return (op & 1); > + return (op & REQ_OP_WRITE); > } > > /*
Nak. Conceptually, an operation is a write if the least significant bit is set. The 1 here doesn't mean REQ_OP_WRITE, it means the least significant bit.
| |