lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/usb/storage/sddr55.c: Remove duplicate header
On Thu, Jan 10, 2019 at 01:10:25PM +0530, Sabyasachi Gupta wrote:
> Remove unusual_sddr55.h which is included more than once
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
> drivers/usb/storage/sddr55.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/storage/sddr55.c b/drivers/usb/storage/sddr55.c
> index b8527c5..96bf7ee 100644
> --- a/drivers/usb/storage/sddr55.c
> +++ b/drivers/usb/storage/sddr55.c
> @@ -62,7 +62,6 @@ MODULE_DEVICE_TABLE(usb, sddr55_usb_ids);
> }
>
> static struct us_unusual_dev sddr55_unusual_dev_list[] = {
> -# include "unusual_sddr55.h"
> { } /* Terminating entry */
> };

As Oliver said on the other patch, this breaks the code. Please do not
blindly make changes without understanding what the code does.

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-01-11 10:11    [W:0.042 / U:1.960 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site