Messages in this thread | | | Subject | Re: [PATCH v3 3/6] gpio: add irq domain activate/deactivate functions | From | Stephen Boyd <> | Date | Fri, 11 Jan 2019 14:05:49 -0800 |
| |
Quoting Brian Masney (2019-01-09 17:12:55) > This adds the two new functions gpiochip_irq_domain_activate and > gpiochip_irq_domain_deactivate that can be used as the activate and > deactivate functions in the struct irq_domain_ops. This is for > situations where only gpiochip_{lock,unlock}_as_irq needs to be called. > SPMI and SSBI GPIO are two users that will initially use these > functions. > > Signed-off-by: Brian Masney <masneyb@onstation.org> > --- > Stephen: Reply if you want a Suggested-by tag for this.
Sure. Add it please.
Suggested-by: Stephen Boyd <sboyd@kernel.org>
Minor question but otherwise
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
> +/** > + * gpiochip_irq_domain_deactivate() - Unlock a GPIO used as an IRQ > + * @domain: The IRQ domain used by this IRQ chip > + * @data: Outermost irq_data associated with the IRQ > + * > + * This function is a wrapper that will call &gpiochip_unlock_as_irq and is to
Is this kernel-doc notation to refer to functions and structures with ampersand only? According to the docs[1] we should put () after functions and '&struct' before structures.
> + * be used as the deactivate function for the struct &irq_domain_ops. The > + * host_data for the IRQ domain must be the struct &gpiochip. > + */ > +void gpiochip_irq_domain_deactivate(struct irq_domain *domain, > + struct irq_data *data) > +{ > + struct gpio_chip *chip = domain->host_data; > +
[1] https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html?highlight=cross%20references#highlights-and-cross-references
| |