lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] x86/fpu/init: Add __setup() functions back to fpu/init.c
Date
It doesn't consistent with document: https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html 
I met an init which didn't accept unknown arguments.

Haoyu

-----Original Message-----
From: Sebastian Andrzej Siewior [mailto:bigeasy@linutronix.de]
Sent: Friday, January 11, 2019 4:12 PM
To: Tang, Haoyu <haoyu.tang@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>; Ingo Molnar <mingo@redhat.com>; Borislav Petkov <bp@alien8.de>; H. Peter Anvin <hpa@zytor.com>; x86@kernel.org; Andy Lutomirski <luto@kernel.org>; Nicolai Stange <nstange@suse.de>; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/fpu/init: Add __setup() functions back to fpu/init.c

On 2019-01-11 10:45:53 [+0800], Haoyu Tang wrote:
> __setup() functions were removed in:
>
> commit 4f81cbafcce2 ("x86/fpu: Fix early FPU command-line parsing")
>
> caused that FPU parameter is passed as an argument to init, the dummy
> __setup() functions can avoid this.

why is that bad?

Sebastian
\
 
 \ /
  Last update: 2019-01-11 09:30    [W:0.056 / U:0.944 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site