lkml.org 
[lkml]   [2019]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rbtree: fix the red root
On Fri, Jan 11, 2019 at 01:12:36PM -0500, Qian Cai wrote:
> On Fri, 2019-01-11 at 09:31 -0800, Matthew Wilcox wrote:
> > On Fri, Jan 11, 2019 at 11:51:45AM -0500, Qian Cai wrote:
> > > Reported-by: Esme <esploit@protonmail.ch>
> > > Signed-off-by: Qian Cai <cai@lca.pw>
> >
> > What change introduced this bug?  We need a Fixes: line so the stable
> > people know how far to backport this fix.
>
> It looks like,
>
> Fixes: 6d58452dc06 (rbtree: adjust root color in rb_insert_color() only when
> necessary)
>
> where it no longer always paint the root as black.
>
> Also, copying this fix for the original author and reviewer.
>
> https://lore.kernel.org/lkml/20190111165145.23628-1-cai@lca.pw/

Great, thanks! We have a test-suite (lib/rbtree_test.c); could you add
a test to it that will reproduce this bug without your patch applied?

\
 
 \ /
  Last update: 2019-01-11 19:16    [W:0.075 / U:4.516 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site