Messages in this thread | | | Subject | Re: [PATCH] gcov: use struct_size() in kzalloc() | From | Peter Oberparleiter <> | Date | Fri, 11 Jan 2019 16:59:08 +0100 |
| |
On 09.01.2019 18:24, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding the > size of a structure that has a zero-sized array at the end, along with memory > for some number of elements for that array. For example: > > struct foo { > int stuff; > void *entry[]; > }; > > instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can now > use the new struct_size() helper: > > instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL); > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Looks sane.
Reviewed-by: Peter Oberparleiter <oberpar@linux.ibm.com>
Andrew, could you pick this patch up?
-- Peter Oberparleiter Linux on Z Development - IBM Germany
| |