Messages in this thread | | | From | Anup Patel <> | Date | Thu, 10 Jan 2019 20:46:51 +0530 | Subject | Re: [PATCH] tty/serial: emit CR before NL in RISC-V SBL console |
| |
On Thu, Jan 10, 2019 at 7:37 PM Andreas Schwab <schwab@suse.de> wrote: > > Signed-off-by: Andreas Schwab <schwab@suse.de> > --- > drivers/tty/serial/earlycon-riscv-sbi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/earlycon-riscv-sbi.c b/drivers/tty/serial/earlycon-riscv-sbi.c > index e1a551aae3..9c51b945b5 100644 > --- a/drivers/tty/serial/earlycon-riscv-sbi.c > +++ b/drivers/tty/serial/earlycon-riscv-sbi.c > @@ -15,8 +15,11 @@ static void sbi_console_write(struct console *con, > { > int i; > > - for (i = 0; i < n; ++i) > + for (i = 0; i < n; ++i) { > + if (s[i] == '\n') > + sbi_console_putchar('\r');
Instead of doing '\n' handling here, we should do it in BBL or OpenSBI (i.e. SBI runtime firmware) otherwise all users of SBI_CONSOLE_PUTCHAR (namely, Linux, FreeBSD, FreeRTOS, U-Boot S-mode, etc) will endup having '\n' handling.
Currently, the BBL does not handle it but we have already handled this in upcoming OpenSBI.
The SBI_CONSOLE_PUTCHAR is comparable to ARM semihosting early prints (refer, tty/serial/earlycon-arm-semihost.c). Even in ARM semihosting early prints the '\n' is not explicitly handled.
Regards, Anup
| |