Messages in this thread | | | Subject | [BUG] net: huawei: hinic: a possible sleep-in-atomic-context bug in hinic_get_stats64 | From | Jia-Ju Bai <> | Date | Fri, 11 Jan 2019 10:18:46 +0800 |
| |
The driver may sleep while holding a RCU lock. The function call path (from bottom to top) in Linux-4.17 is:
[FUNC] down drivers/net/.../hinic/hinic_main.c, 775: down in hinic_get_stats64 net/core/dev.c, 8278: [FUNC_PTR]hinic_get_stats64 in dev_get_stats net/core/net-sysfs.c, 568: dev_get_stats in netstat_show net/core/net-sysfs.c, 565: _raw_read_lock in netstat_show
Note that [FUNC_PTR] means a function pointer call.
This bug is found by my static analysis tool (DSAC-2) and checked by my manual code review.
I do not know how to correctly fix this bug, so I just report it. A possible way may be to replace up() and down() with spin_lock() and spin_unlock().
Best wishes, Jia-Ju Bai
| |