lkml.org 
[lkml]   [2018]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 3/8] x86/mm: break out user address space handling
    On Fri, Sep 07, 2018 at 12:48:57PM -0700, Dave Hansen wrote:
    > +static noinline void
    > +__do_page_fault(struct pt_regs *regs, unsigned long hw_error_code,
    > + unsigned long address)
    > +{
    > + prefetchw(&current->mm->mmap_sem);
    > +
    > + if (unlikely(kmmio_fault(regs, address)))
    > + return;
    > +
    > + /* Was the fault on kernel-controlled part of the address space? */
    > + if (unlikely(fault_in_kernel_space(address)))
    > + do_kern_addr_space_fault(regs, hw_error_code, address);
    > + else
    > + do_user_addr_space_fault(regs, hw_error_code, address);
    > +}

    How about: do_{user,kernel}_fault() ? That _addr_space_ is just a lot of
    typing for no real benefit imo.

    \
     
     \ /
      Last update: 2018-09-08 11:39    [W:5.102 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site