lkml.org 
[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH AUTOSEL 4.4 01/30] usb: usbtest: use irqsave() in USB's complete callback
    On Fri, Sep 07, 2018 at 12:38:56AM +0000, Sasha Levin wrote:
    > From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    >
    > [ Upstream commit 6f3fde684d0232e66ada3410f016a58e09a87689 ]
    >
    > The USB completion callback does not disable interrupts while acquiring
    > the lock. We want to remove the local_irq_disable() invocation from
    > __usb_hcd_giveback_urb() and therefore it is required for the callback
    > handler to disable the interrupts while acquiring the lock.
    > The callback may be invoked either in IRQ or BH context depending on the
    > USB host controller.
    > Use the _irqsave() variant of the locking primitives.
    >
    > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Acked-by: Alan Stern <stern@rowland.harvard.edu>
    > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    > ---
    > drivers/usb/misc/usbtest.c | 10 ++++++----
    > 1 file changed, 6 insertions(+), 4 deletions(-)

    And dropped here.

    \
     
     \ /
      Last update: 2018-09-07 07:45    [W:2.887 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site