lkml.org 
[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 022/145] media: Revert "[media] tvp5150: fix pad format frame height"
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Javier Martinez Canillas <javierm@redhat.com>

    commit 1831af092308aa5a59ae61e47494e441c8be6b93 upstream.

    This reverts commit 0866df8dffd514185bfab0d205db76e4c02cf1e4.

    The v4l uAPI documentation [0] makes clear that in the case of interlaced
    video (i.e: field is V4L2_FIELD_ALTERNATE) the height refers to the number
    of lines in the field and not the number of lines in the full frame (which
    is twice the field height for interlaced formats).

    So the original height calculation was correct, and it shouldn't had been
    changed by the mentioned commit.

    [0]:https://linuxtv.org/downloads/v4l-dvb-apis/uapi/v4l/subdev-formats.html

    Fixes: 0866df8dffd5 ("[media] tvp5150: fix pad format frame height")

    Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
    Cc: <stable@vger.kernel.org> # for v4.12 and up
    Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/i2c/tvp5150.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/media/i2c/tvp5150.c
    +++ b/drivers/media/i2c/tvp5150.c
    @@ -872,7 +872,7 @@ static int tvp5150_fill_fmt(struct v4l2_
    f = &format->format;

    f->width = decoder->rect.width;
    - f->height = decoder->rect.height;
    + f->height = decoder->rect.height / 2;

    f->code = MEDIA_BUS_FMT_UYVY8_2X8;
    f->field = V4L2_FIELD_ALTERNATE;

    \
     
     \ /
      Last update: 2018-09-07 23:59    [W:4.238 / U:0.956 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site